Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace std; usage #3

Open
serpel opened this issue Jun 22, 2018 · 0 comments
Open

Remove namespace std; usage #3

serpel opened this issue Jun 22, 2018 · 0 comments

Comments

@serpel
Copy link
Member

serpel commented Jun 22, 2018

namespace std; should not be used at all, instead we should use std:: everywhere.
This is to avoid conflicts with users who have custom implementations of string or vector for example.

So all references like this should be removed
https://github.com/Rosalila/RosalilaEngine/blob/master/Rosalila.h#L5

And std:: should be added everywere needed:
https://github.com/Rosalila/RosalilaEngine/blob/master/RosalilaParser/RosalilaParser.cpp#L10
This line, for example should become std::map<std::string,std::string> attributes;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant