Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class in loader.py #12

Open
cool-RR opened this issue Jan 25, 2014 · 3 comments
Open

Fix class in loader.py #12

cool-RR opened this issue Jan 25, 2014 · 3 comments

Comments

@cool-RR
Copy link
Contributor

cool-RR commented Jan 25, 2014

The dynamically defined class in loader.py causes bugs on Python 3 when using multiple sub-loaders, since there are multiple InnerLoader classes defined in the same scope and the latter overrides the formers' names, which causes an exception when calling super.

I suggest fixing it by having a separate function that'll dynamically define the class. (Or the best way would be to find a way to get rid of the dynamically defined class.)

@jiaaro
Copy link
Member

jiaaro commented Feb 3, 2014

Yeah, I think the current approach is suffering a bit from my getting too clever. Would like to simplify it when I have some free time (which of course never seems to happen)

@cool-RR
Copy link
Contributor Author

cool-RR commented Feb 19, 2014

FYI: Currently you can't use multiple sub-loaders to the Shpaml loader in Python 3.

@l0kix2
Copy link

l0kix2 commented Mar 23, 2014

It seems that multiple subloaders feature doesn't work in python 2.x also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants