MSI installer - redundancy in public properties

[AndrewDemski-ad-gmail-com]

Winget-AutoUpdate/Sources/Wix/build.wxs

Line 26 in a63a395

<RegistrySearch Id="POWERSHELLEXE" Type="raw" Root="HKLM" Key="SOFTWARE\Microsoft\PowerShell\1\ShellIds\Microsoft.PowerShell" Name="Path" />

We are expanding the POWERSHELLEXE property during AppSearch action, but we are not using it later and we end up with
those two little monsters:

Winget-AutoUpdate/Sources/Wix/build.wxs

Lines 254 to 255 in a63a395

<SetProperty Id="CA_PowerShell_Install" Before="CA_PowerShell_Install" Sequence="execute" Value="&quot;[%SystemDrive]\Windows\Sysnative\WindowsPowerShell\v1.0\powershell.exe&quot; -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -File &quot;[INSTALLDIR]config\WAU-MSI_Actions.ps1&quot; &quot;[B_W_LIST_PATH]&quot; -InstallPath &quot;[INSTALLDIR]\&quot; -CurrentDir &quot;[CURRENTDIRECTORY]&quot;" />

<SetProperty Id="CA_PowerShell_Uninstall" Before="CA_PowerShell_Uninstall" Sequence="execute" Value="&quot;[%SystemDrive]\Windows\Sysnative\WindowsPowerShell\v1.0\powershell.exe&quot; -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -File &quot;[INSTALLDIR]config\WAU-MSI_Actions.ps1&quot; &quot;[B_W_LIST_PATH]&quot; -InstallPath &quot;[INSTALLDIR]\&quot; -Upgrade &quot;#[UPGRADINGPRODUCTCODE]&quot; -Uninstall" />

Shouldn't it be consistent/reused?

reference (using file Id for ps1 script): https://stackoverflow.com/questions/14045955/run-powershell-script-from-wix-installer

[Romanitho]

I did this because of the Sysnative command. But perhaps it can be done differently.

[AndrewDemski-ad-gmail-com]

I did this because of the Sysnative command. But perhaps it can be done differently.

You are right, msi file produed by wix uses Wix4UtilCA_X86.dll which suggests x86 context. sysnative must stay.

It somehow skipped my attention.

[AndrewDemski-ad-gmail-com]

After some digging I found that:
https://wixtoolset.org/docs/tools/wixext/quietexec/#architecture-specific-custom-action-dlls

The $(sys.BUILDARCHSHORT) preprocessor variable contains the suffix you need for the custom action DLL id based on the architecture of the package you're building. For example, you can use BinaryRef="Wix4UtilCA_$(sys.BUILDARCHSHORT)" in your CustomAction authoring.

There is an example of how CA XML node should look like.
I think that it will remove the dependency for sysnative usage..

..at least according to that documentation:
https://wixtoolset.org/docs/tools/wixext/quietexec/#64-bit-awareness

[github-actions]

This issue is stale because it has been open for 30 days with no activity.