Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a method does not update the editor #376

Open
keinstein opened this issue Nov 17, 2021 · 6 comments
Open

Adding a method does not update the editor #376

keinstein opened this issue Nov 17, 2021 · 6 comments

Comments

@keinstein
Copy link

When I add a Lua method from the panel editor while the Lua editor is open, the list of existing functions is not updated.

The file should appear immediately in the side bar, not only after closing and reopening the Lua editor.

@dobo365
Copy link

dobo365 commented Nov 17, 2021

Hi. Maybe worth mentioning which version you are using...
I'm using 5.3.201 and there is no issue like that (if I understand your issue well).
When adding a method in a method group, the method is directly appearing based on the selected template in that method group.

@keinstein
Copy link
Author

As far as I know there are no usable versions for Linux.
See #324, #294
I'm using master, updated yesterday.

You misunderstand me.
First open the Lua editor window.
Then open the panel editor, klick on any control. Klick somewhere in the property pane on a „new function“ button while the Lua editor window is still open. Add the function.
When you now go to the Lua editor window the function seems not to be added.
Close the editor window and reopen it. Surprisingly there appeared a new function.

BTW. Adding a function from the Lua editor is dangerous as it is not always clear which template to use.
Unfortunately reorganizing the function tree does not always work (at least on

@Godlike-Productions
Copy link

I've always found on windows that the tree updates if you close the LUA editor and reopen it (or maybe save the panel and reload it). It's a pain, but normally only mildly annoying.

@dobo365
Copy link

dobo365 commented Nov 29, 2021

I have myself always worked directly in the tree and selected the template there.
The template names are pretty good.
Never had any issue...
After a while you can also simply copy/paste your code from an existing method to a new empty one (of course as long as the same component/modulator type is concerned).

@keinstein
Copy link
Author

@Godlike-Productions @dobo365 A bug is a bug is a bug. And this one is annoying, if you are using a comfortable(tm) editor like Notepad++, Emacs or vim. Even if there is a workaround, a bug is worth to be fixed.

Everything that is even mildly annoying makes users think your software is crap. Look at the typical flamewars äbout $Software or $OperatingSystem of your choice and some alternatives.

Btw: The template names are not really self-explanatory, especially for non-native English speakers. Trying to use the right one, I had chosen the wrong template.

@Godlike-Productions
Copy link

Godlike-Productions commented Nov 30, 2021

@keinstein I'm not disputing that it is a bug. It's unlikely to get a fix in the short term unless someone takes on development as Atom seems to be busy with other things. This is merely the workaround I use with Github, so I can still build stuff.

I notice that you've lodged pull request to stop duplication when methods are exported though, which will fix one annoying aspect of ctrlr. Thanks for your contributions. Hopefully Atom gets to this soon, and hopefully he appoints some others to help manage this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants