Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify Password and Note Card #19

Closed
wants to merge 2 commits into from
Closed

Beautify Password and Note Card #19

wants to merge 2 commits into from

Conversation

kartikjoshi267
Copy link

Description

  • Changed some CSS of Password and Note Card.
  • Imported Poppins font to be used in the Modals.

Fixes #18

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • Update requirements.txt
  • Any database changes required

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been published in downstream modules

@netlify
Copy link

netlify bot commented Oct 6, 2022

👷 Deploy request for vaultsafe pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9603dc1

@RohanKaran RohanKaran marked this pull request as ready for review October 6, 2022 12:39
@RohanKaran
Copy link
Owner

@kartikjoshi267 The view button & delete buttons are not aligned properly in PasswordCard. Also in NoteCard the content is not properly aligned on the right side

@RohanKaran RohanKaran marked this pull request as draft October 6, 2022 12:42
@kartikjoshi267 kartikjoshi267 deleted the Issue-#18 branch October 7, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beautify the NoteCard and PasswordCard
2 participants