From df81dcd371de0ae828eaef1f36c435a47cc02608 Mon Sep 17 00:00:00 2001 From: MateusStano Date: Wed, 7 Feb 2024 14:27:55 +0100 Subject: [PATCH 1/2] BUG: consider only half of ellipse in shape vector --- rocketpy/rocket/aero_surface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rocketpy/rocket/aero_surface.py b/rocketpy/rocket/aero_surface.py index a72fb74cc..e3d9e6a0f 100644 --- a/rocketpy/rocket/aero_surface.py +++ b/rocketpy/rocket/aero_surface.py @@ -1547,7 +1547,7 @@ def evaluate_geometrical_parameters(self): return None def evaluate_shape(self): - angles = np.arange(0, 360, 5) + angles = np.arange(0, 180, 5) x_array = self.root_chord / 2 + self.root_chord / 2 * np.cos(np.radians(angles)) y_array = self.span * np.sin(np.radians(angles)) self.shape_vec = [x_array, y_array] From 3972de41b62e39b4c7237015b771fa8b9361c6ba Mon Sep 17 00:00:00 2001 From: MateusStano Date: Wed, 7 Feb 2024 14:42:45 +0100 Subject: [PATCH 2/2] MNT: update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1137336a0..a6d7dd1d7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,7 +44,7 @@ straightforward as possible. - ENH Precalculate Barometric Height [#511](https://github.com/RocketPy-Team/RocketPy/pull/511) - MNT: Encapsulate quaternion conversions [#537](https://github.com/RocketPy-Team/RocketPy/pull/537) - MNT: improve the low pass filter and document an example [#538](https://github.com/RocketPy-Team/RocketPy/pull/538) - +- BUG: Elliptical Fins Draw [#548](https://github.com/RocketPy-Team/RocketPy/pull/548) ### Fixed