-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Dispersion Class Overhaul #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see things coming to shape.
You mentioned something not working on the simulation it the PR description, in the notebook there is an error in the creation of an mc_rocket.create_object()
. Is that what you meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactor here, some of the changes are already contributing to a better understanding of the class in general.
The notebook is not running to the following problem:
AttributeError: 'Dispersion' object has no attribute 'print_results'
We should keep working on the Dispersion/Monte Carlo feature and improve it to release it by version v1.3.0, hopefully soon enough!
All comments addressed @Gui-FernandesBR @phmbressan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request type
Description
Did a big refactor on the Dispersion Class, it is working perfectly now. Simulations can be ran perfectly.
I did not touch anything relating to plots, prints or tests. So tests will not pass.
Some things for the future:
exportables
list needs to be reviewedNext PR will be renaming all the classes.