Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: 3-DOF simulation #655

Open
Gui-FernandesBR opened this issue Aug 19, 2024 · 3 comments · May be fixed by #745
Open

ENH: 3-DOF simulation #655

Gui-FernandesBR opened this issue Aug 19, 2024 · 3 comments · May be fixed by #745
Labels
Flight Flight Class related features Good first issue Good for newcomers

Comments

@Gui-FernandesBR
Copy link
Member

Gui-FernandesBR commented Aug 19, 2024

Allow RocketPy to run a point-mass simulation (3DOF).

Important aspects of this issue:

  • You should modify the flight class to add an option to run a simulation with 3DOF of 6DOF (current model). A similar approach is currently done with the equations_of_motion argument in the Flight class constructor.
  • The 3DOF simulation should run faster than our current model!
  • When using the 3DOF model, is is expected that the user may skip a few steps of the rocketpy workflow. For example, user do not needs to set moments of inertia since it will not be used for calculations.
  • However, I personally believe it would be a good application to being able to run the same Rocket object with both 3DOF and 6DOF models so we can easily compare the models.

Optionally, one may create a new FlightClass, in case you find it easier. However, I don't really appreciate this approach. I think the "giant Flight class with different options" may be a better option.

Please read the thread below to achieve a better understanding!

@Gui-FernandesBR Gui-FernandesBR added Good first issue Good for newcomers Flight Flight Class related features labels Aug 19, 2024
@Gui-FernandesBR
Copy link
Member Author

@chasgior214
Copy link

For sure!

What is the goal of having 3 DOF simulations in RocketPy? I think the best way to implement it would depend on the goal(s) of having it.

@LUCKIN13
Copy link
Contributor

The ability to choose between 6DoF or 3DoF simulation modes allows users to simulate without requiring extensive data, such as the rocket's inertia. This makes RocketPy useful for preliminary design phases, where only basic parameters like mass and drag are needed to estimate the rocket's apogee, without concern for stability.

This feature will need to undergo testing, but we believe it could become a valuable tool, enabling RocketPy to support the rocket's development process from initial design to launch.

aZira371 added a commit to aZira371/RocketPy that referenced this issue Dec 3, 2024
ENH: adds 3 DOF simulation capability to rocketpy.Flight.

*ENH: added "u_dot_3dof" for "solid_propulsion"
mode

*ENH: adding "u_dot_generalized_3dof" for "standard"
mode (still incomplete)

*ENH: new parameter "simulation_mode" for swtiching
between 3 dof and 6 dof

*ENH: updated conditions for "__init_equations_of_motion"

*ENH: 2 new example files have been created to test 3 dof model
"test_bella_lui_flight_sim" and "test_camoes_flight_sim"
@aZira371 aZira371 linked a pull request Dec 3, 2024 that will close this issue
7 tasks
@Lucas-Prates Lucas-Prates linked a pull request Dec 4, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flight Flight Class related features Good first issue Good for newcomers
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants