Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: display both power_off_drag and power_on_drag in a single plot #528

Closed
Gui-FernandesBR opened this issue Jan 12, 2024 · 0 comments · Fixed by #547
Closed

ENH: display both power_off_drag and power_on_drag in a single plot #528

Gui-FernandesBR opened this issue Jan 12, 2024 · 0 comments · Fixed by #547
Assignees
@juliomachad0
Labels
Enhancement New feature or request, including adjustments in current codes Good first issue Good for newcomers Outputs Dedicated to visualizations enhancements like prints and plots
Milestone
Release v1.X.0

Comments

@Gui-FernandesBR
Copy link
Member

Is your feature request related to a problem? Please describe.

This one is similar to the #527 . It's not so good to visualize two different plots that represents the same parameters.
Also, visualizing power on and power off drag curves at the same chart allows us to easily compare them.

Describe the solution you'd like

  • Use the Function.compare_plots method to plot both curves in a single plot, possibly changing the style of one curve to have discontinued dots.
  • I would try to add a grey rectangle covering the transonic region.
@Gui-FernandesBR Gui-FernandesBR added Enhancement New feature or request, including adjustments in current codes Good first issue Good for newcomers Outputs Dedicated to visualizations enhancements like prints and plots labels Jan 12, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Jan 12, 2024
@Gui-FernandesBR Gui-FernandesBR linked a pull request Feb 7, 2024 that will close this issue
ENH: Plotting both power on and off drag curves in a single plot. #547
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Closed in LibDev Roadmap Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliomachad0 juliomachad0

Labels
Enhancement New feature or request, including adjustments in current codes Good first issue Good for newcomers Outputs Dedicated to visualizations enhancements like prints and plots
Projects
LibDev Roadmap
Status: Closed
Milestone
Release v1.X.0
Development

Successfully merging a pull request may close this issue.

ENH: Plotting both power on and off drag curves in a single plot. RocketPy-Team/RocketPy
3 participants
@Gui-FernandesBR @juliomachad0 @dipesh2212