Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: _check_user_input method being called multiple times #481

Closed
lucasfourier opened this issue Nov 23, 2023 · 2 comments · Fixed by #581 or #582
Closed

ENH: _check_user_input method being called multiple times #481

lucasfourier opened this issue Nov 23, 2023 · 2 comments · Fixed by #581 or #582
Labels
Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class
Milestone
Release v1.X.0

Comments

@lucasfourier
Copy link
Contributor

lucasfourier commented Nov 23, 2023 •
edited
Loading

Describe the bug

The _check_user_input method is being called multiple times for some unexpected reason during init for the same source file.

Expected behavior

Processing should not result in redundant calculations and function calls.

Additional context

This discussion arised from a hotfix. For additional information, one should read the following: #478
@lucasfourier lucasfourier added the Bug Something isn't working label Nov 23, 2023
@Gui-FernandesBR Gui-FernandesBR changed the title BUG: _check_user_input method ENH: _check_user_input method being called multiple times Nov 23, 2023
@Gui-FernandesBR
Copy link
Member

I'm not sure if this is a bug, it was exactly what was intended.
An optimization is more than welcome tho, calling it multiple times is a bad idea.

@lucasfourier
Copy link
Contributor Author

True. Changing the label.

@lucasfourier lucasfourier added Enhancement New feature or request, including adjustments in current codes and removed Bug Something isn't working labels Nov 23, 2023
@Gui-FernandesBR Gui-FernandesBR moved this from Backlog to Next Version in LibDev Roadmap Nov 25, 2023
@MateusStano MateusStano moved this from Next Version to Mid-Term in LibDev Roadmap Nov 29, 2023
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Dec 3, 2023
@phmbressan phmbressan mentioned this issue Dec 21, 2023
Merged
7 tasks
@Gui-FernandesBR Gui-FernandesBR added the Function Everything related to the Function class label Mar 26, 2024
@Gui-FernandesBR Gui-FernandesBR mentioned this issue Mar 26, 2024
Merged
7 tasks
@Gui-FernandesBR Gui-FernandesBR linked a pull request Mar 26, 2024 that will close this issue
ENH: Flight simulation speed up #581
Merged
7 tasks
@Gui-FernandesBR Gui-FernandesBR linked a pull request Apr 19, 2024 that will close this issue
ENH: Function Validation Rework & Swap np.searchsorted to bisect_left #582
Merged
7 tasks
@Gui-FernandesBR Gui-FernandesBR moved this from Mid-Term to Next Version in LibDev Roadmap Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request, including adjustments in current codes Function Everything related to the Function class
Projects
LibDev Roadmap
Status: Closed
Milestone
Release v1.X.0
2 participants
@Gui-FernandesBR @lucasfourier