-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper Error Handling for "Message Too Long" #384
Comments
@abhinavkrin @sidmohanty11 |
yup! I also want to work on this issue. |
Hey @abhinavkrin! 🚀 Just wanted to give you a heads up on the latest changes. Fixed the long message issue in the ChatInput component, now it shows a friendly error toast for character limit exceeded. Also added guidance to send long messages as attachments. No more unexpected logouts! Check it out and let me know if it's all good. 🙌 #384 ✨ |
Hey @sidmohanty11 @abhinavkrin,
Will raise a draft soon! ^^ |
Update :Hey, I have added the longMessgae.mp4Some bugs need attention, I will try to fix them soon and send a PR (or should I send a draft pr, so you can also see the code changes ?) [Any suggestions or feedback would be appreciated] @sidmohanty11 |
Great find, @Akshun-01 , and great work fixing this as well. |
Hello @abhinavkrin @sidmohanty11, |
Description:
In Embedded Chats, if the message is too long then it gives an error message of
Error sending message, log in again.
and logs the user out.
Getting logged out for sending long texts is a not very likely user experience, this should be properly handled with an Error message ( similar to what is done on RocketChat).
Steps to reproduce:
Expected behavior:
Actual behavior:
Screencast.from.01-02-2024.05.52.29.PM.webm
The text was updated successfully, but these errors were encountered: