Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG (style) ] remove unwanted await in sync operation and add required await #51

Open
Nabhag8848 opened this issue Feb 20, 2023 · 0 comments
Open

[BUG (style) ] remove unwanted await in sync operation and add required await #51

Nabhag8848 opened this issue Feb 20, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Nabhag8848
Copy link
Contributor

Description:

  • There are lot of places where there is await within the SYNC operation. specially when getting the userInfo, interactionData from context and creating the messageBuilder (textSender) which needs to be removed as await is only for async operation/ function-calls.
  • Similarly there are places where await are missing in async calls which needs to fix.

Steps to reproduce:

  1. look into file changes

Expected behavior:

  • remove await from sync and add missing await in async operation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(style): removed unwanted, added await in async operation Nabhag8848/Apps.Github22
1 participant
@Nabhag8848