autoclear and highlights implementation makes custom objects invisible in certain cases

[trusktr]

This line,

ros3djs/src/visualization/Viewer.js

Line 58 in 530f7ec

this.renderer.autoClear = false;

paired with this line,

ros3djs/src/visualization/Viewer.js

Line 135 in 530f7ec

this.renderer.clear(true, true, true);

and this line,

ros3djs/src/visualization/Viewer.js

Line 137 in 530f7ec

this.highlighter.renderHighlights(this.scene, this.renderer, this.camera);

is making it difficult to stick custom objects into the Three.js scene. It makes them become invisible. I had to disable these three lines in a work project in order for Mesh (and similar) APIs to work properly.

suggestion:

I believe there is a better solution to this that doesn't cause a break in people's (three.js developer's) expectations. For example, we can implement highlights as a post-processing effect and otherwise not modify the WebGLRenderer with these lines that cause unexpected effects during conventional usage of Mesh (and similar) APIs.

Here are examples of how to do that:

• https://threejs.org/examples/?q=select#webgl_postprocessing_unreal_bloom_selective
• https://threejs.org/examples/?q=postpro#webgl_postprocessing_outline

Also, here is a much more robust and featureful postprocessing lib compared to what is built into Three.js: https://github.com/vanruesc/postprocessing

---

Sorry if I didn't explain the issue well, it's been a while, I just remember thinking of a better way to do it at the time.