Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message generation fails on Rolling due to unsupported *.idl files in ros2bag pkg #890

Closed
wayneparrott opened this issue Jan 27, 2023 · 2 comments · Fixed by #891
Closed
Labels

Comments

@wayneparrott
Copy link
Collaborator

The Rolling distro for windows includes the rosbag2_storage_mcap_testdata pkg. In this package there is a the ComplexMsgDependsOnIdl.msg which includes BasicIdl.idl. The rclnodejs message generator only parses *.msg and *.srv files at this time. Thus the message generator fails with an error. Note that message generation is part of the npm install process for rclnodejs. Thus rclnodejs 0.21.4 can not be used with the Rolling distro on Windows at this time.

@wayneparrott
Copy link
Collaborator Author

A quick solution is to introduce a mechanism for filtering packages and messages that should not be generated. The run_test.js script uses a blocklist.json file to filter test files by OS. I propose we introduce a similar feature for specifying packages and messages to be filtered from the message generation process. Thoughts?

example filter spec:

interface MsgGenFilter {
  pkg: Regexp;
  os?: Regexp;
  message?: Regexp;
}

Thoughts?

@minggangw
Copy link
Member

Related issue #764

wayneparrott added a commit to wayneparrott/rclnodejs that referenced this issue Jan 31, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix RobotWebTools#890
wayneparrott added a commit to wayneparrott/rclnodejs that referenced this issue Jan 31, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix RobotWebTools#890
wayneparrott added a commit to wayneparrott/rclnodejs that referenced this issue Jan 31, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix RobotWebTools#890
minggangw pushed a commit that referenced this issue Feb 24, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix #890
wayneparrott added a commit to wayneparrott/rclnodejs that referenced this issue Feb 26, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix RobotWebTools#890
minggangw pushed a commit that referenced this issue Apr 3, 2023
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a
repeatable issue with node-gyp configuration on node 18.13. It seems to
be related to the node cache. Switching to 18.12 avoids using a cached
version of node 18 and the issue no longer occurs.

Fix #890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants