Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Remove empty create_request() method from all tactics #1665

Open
kfu02 opened this issue Jun 15, 2021 · 0 comments
Open

[TODO] Remove empty create_request() method from all tactics #1665

kfu02 opened this issue Jun 15, 2021 · 0 comments
Labels
exp / novice (1) priority / low pull request todo From a TODO in code

Comments

@kfu02
Copy link
Contributor

kfu02 commented Jun 15, 2021

Pull request: #1644

Link to TODO, or file number/line: https://github.com/RoboJackets/robocup-software/pull/1664/files/9110c0867e4e7c8b66d5f93e1a09674103633bbf#diff-5498d04d130b1bbc4734fad315df34a8d9b63769212ae2ff60af9e6453a54e0a

Every tactic has a create_request() method that doesn't do anything. This should be deleted at the interface level and then subsequently from each tactic,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp / novice (1) priority / low pull request todo From a TODO in code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfu02