Update to sails v.0.10.x? #23
Comments
|
Hey @TechnoX, How did you install tournamenter? Just by running |
|
I already had sails installed before I ran npm install. I can try to uninstall sails and then redo the install command :) But I think we should move forward asap and not be dependent on old (deprecated) software :) |
Ok, well, I was under the impression that What I'd suggest would be indeed uninstalling sails then.
Please do not get me wrong since I am the last one to talk about sails, but if they use any sensible versioning convention then this version is pre 1.0.0 and ton of stuff can change. Therefore I believe that it makes more sense to use that version we are sure works. On the other hand, I totally understand what you are saying by not using/being dependent on old software. Although Node.JS community is very vibrant and alive I think that using a version that is 13 months old does not necessary mean depending on old software. I also hope you will not need to install tournamenter anymore in the future if we manage to get #22 running. Also, I am very much looking forward to the Map editor. Do let us know how we can help! |
|
Reinstalled sails with "sudo npm install -g" and got v0.9.7 I still got an error (longer this time) when I press the "+ Create Team" button: |
|
I don't remember pretty well, but there was some problems using the sails
|
|
@TechnoX this is spooky. @ivanseidel once told me not to do |
|
I'm getting home in a hour or two. Will look into it. Can you enter skype Ivan Seidel Gomes
|
|
I tried without -g before, but had some problems that I didn't remember. @ivanseidel : Sure, I'll log in to Skype now :) |
|
Btw, when I have the server up you can reach it here: http://80.217.114.236:8888/ |
|
I can't connect to the mongodb .... Do I need to setup anything before connecting to the mongodb? :) |
|
Well @TechnoX and @mrshu . It's not documented yet, but we have a bunch of options for starting the server. Here a few with lots of customisations that I personally use:
As you can see, I'm not using sails to lift the server, because it needs to use the script inside the I guess you need to assign the adapter's |
|
But it should be the same when I set the default adapter module and url in the adapters.js file, right? and Call me when you have time ;) |
|
@TechnoX that should indeed work, the problem seems to be elsewhere. Version 0.9.7 of sails is indeed in the @ivanseidel I am out of steam here but I bet you will figure this out in 5 minutes. Based on @TechnoX's output it looks like the code never reached a state in which it would actually save something, either via |
|
I've talked to Ivan for 50 minutes and fixed the problem, he has pushed the code to github already :) The problem was that sails-disk was saving the id as an string and couldn't auto-increment the value and therefore skipped the id-value. We changed the datatype to integer and now it works like a charm :) We can close this issue, thanks! :) |
|
Cool, thanks a lot @TechnoX and @ivanseidel! |
|
;)
|
|
Nah, something is still wrong. I can create teams, but when I try to edit their nationality or name I get this error I think the id should be 1 instead of [ [Object] ] |
|
Okay, I don't know what Ivan pushed before, because in api/models/Team.js the id is still an string. It works when I change it to an integer, see below: |
|
@TechnoX cool, thanks a lot for this. Can you please send a pull request? Do let me know if I can be of any help there. If you do not have time for that/don't want to do that I can do it too. |
|
I've never done pull requests before, but I think it was quite straight forward 👍 Let me know if I did anything wrong ;) |
|
@TechnoX you did a very fine job, thanks a ton! |
I don't remember which version of Sails we was using, but now when I installed sails on my server I got 0.10.5
I got some errors, for example when creating a team:
Should we update the code to works out of the box with newer Sails? Or is this a problem with something else not related to the version?
PS. I'm starting to port my map editor for Rescue :)
The text was updated successfully, but these errors were encountered: