-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible improvements from Cysharp/Ulid #23
Comments
I just merged #22, I'll see, at a later date, if something in your PR applies to this. Thanks! |
At a glance the get DateTimeOffset optimisation might apply. My vectorized decode CrockfordBase32 is faster than the manual version, with some slight modifications (currently turns invalid characters into 31) it would probably be an improvement on your current |
Created a pull request with some potential optimizations/code modernisation for Cysharp/Ulidd. Not sure if any changes would apply here, it looks like NUlid and Ulid serialize to Guid in different ways (not 100% sure only glanced at it).
I meant to check if any improvements would apply to NUlid and create a pr, but I've been busy so I'll just dump the work on you 😆
The text was updated successfully, but these errors were encountered: