Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla "Smooth" Double Slabs have inconsistent drops #428

Closed
2 tasks done
connor135246 opened this issue Feb 22, 2024 · 1 comment
Closed
2 tasks done

Vanilla "Smooth" Double Slabs have inconsistent drops #428

connor135246 opened this issue Feb 22, 2024 · 1 comment
Assignees

Comments

@connor135246
Copy link

Initial Questions

  • I have searched this issue tracker and there is nothing similar already, and this is not on the list of known issues. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I have verified that this issue occurs in a SUPPORTED environment, meaning I can reproduce this WITHOUT OptiFine, and without Bukkit+Forge server software like KCauldron, Thermos, Crucible, Mohist etc

Mod Version

2.5.1

Describe the Issue

Breaking minecraft:double_stone_slab:8 drops etfuturum:smooth_stone.
However, breaking minecraft:double_stone_slab:9 does not drop etfuturum:smooth_sandstone and breaking minecraft:double_stone_slab:15 does not drop etfuturum:smooth_quartz. These should probably be consistent.

Relevant code:

@SubscribeEvent
public void onDrops(BlockEvent.HarvestDropsEvent event) {
if (ConfigBlocksItems.enableSmoothStone && event.block == Blocks.double_stone_slab && event.blockMetadata == 8) {
event.drops.clear();
event.drops.add(ModBlocks.SMOOTH_STONE.newItemStack(1));
}
}

Conflicting Mods

No response

Crash Report

No response

Other Details

No response

@Roadhog360
Copy link
Owner

Ooh, nice catch. I forgot about those variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants