Single statement taking minutes to be parsed

[gquerret]

On behalf of CNAF

Proparse can parse this procedure very quickly:

define variable xx as integer extent 20.
define variable sep as character initial ';'.
put unformatted "header" +
            if xx[1] = ? then "" else string(xx[1]) + sep +
            if xx[1] = ? then "" else string(xx[1]) + sep
   .

With 10 nested if / then / else functions in the put statement, then Proparse takes 500 ms.
With 15 nested functions, Proparse takes 2 seconds.
With 20 nested functions, Proparse takes 50 seconds.

[gquerret]

I'll quickly investigate, but it's unlikely to be fixed. Code is ambiguous, and ANTLR has to find all viable paths before choosing one. In this case, the number of paths grows exponentially with the number of if / then / else functions.

[ccecvb]

out of curiosity would brackets help ?

define variable xx as integer extent 20.
define variable sep as character initial ';'.
put unformatted "header" +
            (if xx[1] = ? then "" else string(xx[1])) + sep +
            (if xx[1] = ? then "" else string(xx[1])) + sep
   .

In that case is it possible to have a rule conditional-expressions-should-be-in-brackets ?

[gquerret]

out of curiosity would brackets help ?

Yes, that removes the ambiguity.

In that case is it possible to have a rule conditional-expressions-should-be-in-brackets ?

Could be done

[ccecvb]

@gquerret conditional-expressions-should-be-in-brackets is actually part of our coding convention. Do you prefer that I create a separate enhancement request for such a rule ?

[gquerret]

@ccecvb Yes please