Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Font Awesome 5.0 icons #22

Open
joewheaton opened this issue Feb 28, 2021 · 3 comments
Open

Upgrade Font Awesome 5.0 icons #22

joewheaton opened this issue Feb 28, 2021 · 3 comments
Labels
question Further information is requested

Comments

@joewheaton
Copy link

@MattReimer what are the implications of moving from the Font Awesome 4.x to 5 or 6.x? Would it break all our current references to it, or still work? As we enter a phase of upping our game on marketing, documentation, etc. it might be nice to have that richer range of icons for authors of content to use?

Obviously a low priority, but thought I'd ask.

@joewheaton joewheaton added the question Further information is requested label Feb 28, 2021
@MattReimer
Copy link
Member

Should be fine I think. We'll need to keep track of everywhere icons are used but most should have backwards compatibility

@joewheaton
Copy link
Author

As far as I am aware, it is in virtually all sites using the template...

@MattReimer MattReimer changed the title Do we want to upgrade to Font Awesome 5.0 icons? Upgrade Font Awesome 5.0 icons Mar 1, 2021
MattReimer added a commit that referenced this issue Mar 1, 2021
@MattReimer
Copy link
Member

Did a quick test and it seems like the major version upgrade isn't compatible with what we're doing. This is a bigger effort so let's push it to do at the same time as the Jekyll 4.0 upgrade #13

@MattReimer MattReimer removed their assignment Mar 1, 2021
@MattReimer MattReimer added this to the Jekyll 4.0 Upgrade milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants