Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RS_Context - Geology needs symbology and labels! #561

Open
2 of 20 tasks
joewheaton opened this issue Apr 13, 2023 · 21 comments
Open
2 of 20 tasks

RS_Context - Geology needs symbology and labels! #561

joewheaton opened this issue Apr 13, 2023 · 21 comments
Assignees
Labels
🌐 Viewer Arc Our map viewer plugin for ArcGIS 🌐 Viewer QGIS Our map viewer plugin for QGIS 🌐 Viewer Web Our web map viewer inside the data exchange pkg:RS_Context

Comments

@joewheaton
Copy link
Contributor

joewheaton commented Apr 13, 2023

Maybe symbolize based on MAJOR1 and add label based on ORIG_LABEL; look at documentation for color choices and fill, but make transparent so it can be seen over hillshade and AP #561

Add change to business logic too to make layer appear as multiple layers displayed based on attribute:

  • Major1

  • UnitName

  • Age.

  • Always use the original abbreviation label for the label.

See also: https://youtu.be/Ze60sYAgu9s?t=1295 for WebRV and

To-Do

  • Start new branch with descriptive name for these changes (e.g. RS_Context 2.0)
  • Make necessary edits to business logic and commit to new branch
  • Author *.qml for QRAVE of layer(s) and test in QRAVE and commit
  • Produce screen shot of each qml layer to provide in commit or later pull request for reviewer (include legend). Also, provide warehouse link to riverscape project you did testing on (use same project(s) for testing ArcRAVE and WebRAVE)
  • Make pull request for just QRAVE changes. Choose appropriate reviewer(s)
  • Author *.lyr for ArcRAVE of layer(s) and test in ArcRAVE and commit
  • Make pull request for just ArcRAVE changes. Choose appropriate reviewer(s)
  • Produce screen shot of each lyr file to provide in commit or later pull request for reviewer (include legend)
  • Author symbology files for WebRAVE and provide link in commit to webRAVE of project it can be tested on
  • Make pull request for just WebRAVE changes. Choose appropriate reviewer(s)
  • Author or Update any project type documentation
  • Update or Add Project Views to Reflect Changes (if necc.)
  • After pull request(s) merged, test in updated qRAVE
  • After pull request(s) merged, test in updated ArcRAVE
  • After pull request(s) merged, test in updated WebRAVE
  • Delete local branch(es) you used for your pull request(s)
@joewheaton joewheaton changed the title Geology - maybe symbolize based on MAJOR1 and add label based on ORIG_LABEL; look at documentation for color choices and fill, but make transparent so it can be seen over hillshade and AP RS_Context - Geology needs symbology and labels! Apr 13, 2023
@joewheaton joewheaton added 🌐 Viewer QGIS Our map viewer plugin for QGIS 🌐 Viewer Arc Our map viewer plugin for ArcGIS 🌐 Viewer Web Our web map viewer inside the data exchange pkg:RS_Context labels Apr 13, 2023
@jtgilbert
Copy link
Contributor

fyi @joewheaton @wally-mac @Riverscapes/riverscape-project-curators. This layer has consistent symbology we should use/copy. It's on page 15 of this doc: https://pubs.usgs.gov/ds/1052/ds1052.pdf

@wally-mac
Copy link

@leallysmith I'm assigning this to you. Please delegate as needed. Thanks.

@shelbysawyer
Copy link
Collaborator

If the layer will be given consistent symbology, a legend may be helpful in addition to labels

@leallysmith
Copy link
Collaborator

image
This is the symbology on page 15, it's for the GENERALIZE field which is GENERALIZED_LITH (is this usable in place of MAJOR1? it summarizes MAJOR1-3). Still tracking down symbologies for Unit name and Age.

@jtgilbert
Copy link
Contributor

Yeah I think this looks great @leallysmith. As far as the other fields I don't know if SGMC uses any other symbology so you may have to peruse around and find examples from other geologic maps.

@leallysmith
Copy link
Collaborator

image
This seemed to be a pretty consistent color scheme across different geologic age maps. Should I modify the BL to show both MIN_AGE and MAX_AGE or just one of them? Also, there's about 200 ages that would need to be symbolized. Is there a faster way to symbolize rather than manually assigning colors and typing in every potential age?

@joewheaton
Copy link
Contributor Author

This seemed to be a pretty consistent color scheme across different geologic age maps. Should I modify the BL to show both MIN_AGE and MAX_AGE or just one of them?

Just one is fine. I don't care which.

Also, there's about 200 ages that would need to be symbolized. Is there a faster way to symbolize rather than manually assigning colors and typing in every potential age?

Maybe instead of age, just do epoch to keep it simpler. The color chart from GSA is good.

@joewheaton
Copy link
Contributor Author

Also, make label a little smaller font. And perhaps add rule to not display water label if feasible.

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 1, 2023

@jtgilbert @joewheaton Here is the updated 'GENERALIZE' geology layer.

image

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 1, 2023

@jtgilbert, I'm having a hard time finding an exhaustive list of the UNIT_NAME attributes. Would you know where this is located?

@leallysmith leallysmith removed their assignment Jun 1, 2023
@jtgilbert
Copy link
Contributor

I'm not sure if SGMC manages one or not... the dataset is pulled together from all the States' geologic maps, so they might only exist individually at the state level.

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 1, 2023

@jtgilbert below is the Max Age symbology which uses Epochs as suggested by @joewheaton. Given the tedious nature of this task, I'll wait until you guys approve of this before curating it in Mapbox.

image

@joewheaton
Copy link
Contributor Author

This is looking good. Make sure to add the abbreviations used in labels to legend

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 5, 2023

Will do @joewheaton. @jtgilbert do we have the entire national dataset for this layer? If not, could you point me in the direction of where I can find it?

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 5, 2023

Disregard @jtgilbert I found it.

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 6, 2023

@jtgilbert and @joewheaton, the UNIT_NAME attribute has over 5,500 unique classifications. I can try to use rule-based symbology to group some things together but wanted to confirm that this is worth the time that it will take.

@jtgilbert
Copy link
Contributor

I don't think it is worth the time. The GENERALIZE field or whatever it is that is their default symbology covers basic rock types, and between that and age I think you have the most important info. If someone needs to drill in and see exact unit names, or primary and secondary rock types, etc. they can download and query the data.

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 6, 2023

Sounds good!

@Cashe93
Copy link
Collaborator

Cashe93 commented Jun 10, 2023

@jtgilbert, I'm having trouble figuring out a way to symbolize these in Mapbox (specifically the max ages). The AGE_MAX attribute field contains multiple names per row (each name representing eon, era, period, and epoch) In QGIS we used rule based symbology to isolate the epoch name which required the use of the LIKE operator. For example, in order to symbolize things for the Late-Jurassic epoch, we used the following expression "AGE_MAX" LIKE '%Late_Jurassic%' However, I'm having a hard time figuring out how to do this in Mapbox. Do you know an expression that we could use in the .JSON that is equivalent to what we did in QGIS?

@Cashe93
Copy link
Collaborator

Cashe93 commented Jul 20, 2023

@MattReimer, any luck with the rule-based symbology in MapBox?

@MattReimer
Copy link
Member

I only got a bit of time to look into it but it seems like even simple pattern matching isn't possible (at least not yet).

For now our only option would be to:

  1. Symbolize every possible value
  2. bake the pattern we want into the actual layer.

Sorry if that's disappointing. I'm pretty surprised they still can't support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Viewer Arc Our map viewer plugin for ArcGIS 🌐 Viewer QGIS Our map viewer plugin for QGIS 🌐 Viewer Web Our web map viewer inside the data exchange pkg:RS_Context
Projects
None yet
Development

No branches or pull requests

8 participants