Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find out if we should use a templating engine and/or JS app framework #12

Open
sigurdsvela opened this issue Oct 7, 2015 · 3 comments
Milestone

Comments

@sigurdsvela
Copy link
Member

As per now, we just use the tempting system from wordpress, and code pretty vanilla.

WordPress/PHP tempting engines

There are a lot of good tempting engines for PHP, and plugins that make them work for wordpress. This might be a good idea. It makes the code a lot more readable, and enforces a good separation of logic and templates. i.e., there should never be DB calls in templates, and nothing outside a template should ever display anything.
The discussion here is wether or not riiskit should enforce the usage of a templateing engine

JS App Framework

Should we make riiskit include a JS App framework? Will themes be developed faster/better with one?

This is a discussion for now. So chime in!

@sigurdsvela sigurdsvela changed the title Find out if we should use a templating engine $/| JS app framework Find out if we should use a templating engine and/or JS app framework Oct 8, 2015
@sigurdsvela sigurdsvela added this to the 2.0 milestone Oct 8, 2015
@halvardos
Copy link
Member

I personally LOVE good logic and display separation. IMO we should consider making this a modular part of riiskit as soon as possible, maybe as a new child version of the theme for more 'standard' websites.

A js framework with good integration into the new WP REST api could potentially create a lot of buzz for this theme if we release it together with, or close to, the release of REST-API as part of WP core.

@sigurdsvela
Copy link
Member Author

You and me both. We should find out how to enforce said separation. I vote in favour of MVC.
I think a PHP templateing engine should be included in riiskit(parent), and be used in child, i think all of themes should(at least have the choice to) use a PHP tempting engine if we introduce one.

Agreed, a JS App Framework + WP REST = Bloody EPICNESS

@sigurdsvela
Copy link
Member Author

We need to discuss which tempting engine we should use, and which App framework.

I have close to no experience with JS app frameworks, so I have no suggestions.
I have tried PHP Twig, which is very good. And there exists a plugin to integrate it with WordPress.

Where to people stand on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants