Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making pages that don't get used #85

Open
vteague opened this issue Jun 3, 2022 · 0 comments
Open

Making pages that don't get used #85

vteague opened this issue Jun 3, 2022 · 0 comments
Assignees
@vteague

Comments

@vteague
Copy link
Member

vteague commented Jun 3, 2022

In lines 20-25 of NavigationUtils.cs, there's a confusing construction of a couple of pages that don't actually get used in the event that MPs are not initialised.

Current behaviour: User-facing behaviour isn't actually wrong, but the app is making pages that aren't needed.

Intended behaviour: Don't build pages that aren't needed. In particular, don't build this page if we don't know our MPs.
@vteague vteague self-assigned this Jun 3, 2022
@vteague vteague mentioned this issue Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vteague vteague

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vteague