Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated members #1712

Open
bstordrup opened this issue Jul 2, 2024 · 0 comments
Open

Duplicated members #1712

bstordrup opened this issue Jul 2, 2024 · 0 comments

Comments

@bstordrup
Copy link

In the PropertyModelBase class, a private readonly member JsonSchemaProperty _property is defined and populated in the constructor.

Also, in the derieved PropertyModel class, a private readopnly member JsonSchemaProperty _property is defined and populated in the constructor after passing it to the base constructor.

Is that not inefficient and memory waste? Would it not be a better approach to make the JsonSchemaProperty _property in PropertyModelBase be protected or expose it via a read-only protected property?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant