Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you and a question #1

Open
aniruddhawani opened this issue Aug 10, 2023 · 1 comment
Open

Thank you and a question #1

aniruddhawani opened this issue Aug 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@aniruddhawani
Copy link

The blogpost indicated that our setup wouldn't be affected by this but the tool was handy to verify programmatically. Thank you!

I'd suggest a minor code change (L11) which will cover the case where '*' might not be present in one of the patterns
Recommendation:
if "*" in pattern and pattern.index("*") < pattern.index("/"):
instead of
if pattern.index("*") > 0 and pattern.index("*") < pattern.index("/"):

Happy to open a PR if you prefer that.

@ori-rezonate
Copy link
Contributor

Hi @aniruddhawani , sure feel free to open a PR and we'll process it :)

@ori-rezonate ori-rezonate added the enhancement New feature or request label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants