Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approve and merge pull requests #54

Open
itaykrk opened this issue Mar 24, 2020 · 2 comments
Open

Approve and merge pull requests #54

itaykrk opened this issue Mar 24, 2020 · 2 comments
Labels
Feature Request A new feature that's under consideration.

Comments

@itaykrk
Copy link

itaykrk commented Mar 24, 2020

Currently i'm using ReviewNB to review PRs and then get back to github to approve the PR and merge to the master branch.
It would be great if you'll add the option to approve and merge PRs directly from ReviewNB.
@amit1rrr amit1rrr added the Feature Request A new feature that's under consideration. label Mar 24, 2020
@amit1rrr
Copy link
Member

@itaykrk Thank you. I think "Approve & Merge PR" would be a good button to have on ReviewNB. I just checked that there's an API support available for this as well.

I have marked this as a feature request & will build it in (can't promise any timeline at the moment).

@amit1rrr
Copy link
Member

Additionally, it would be great if we can handle notebook merge conflicts at PR merge time. Be smart enough to automatically handle simple conflicts (e.g. if only metadata is conflicting then no need for human intervention) & offer UI for complicated notebook merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request A new feature that's under consideration.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amit1rrr @itaykrk