Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync conversation status (Resolved | Unresolved) between ReviewNB & GitHub #124

Open
devikasharma97 opened this issue Mar 3, 2023 · 1 comment

Comments

@devikasharma97
Copy link

Whenever I mark a comment as resolved in ReviewNB it still stays unresolved in Github

@amit1rrr
Copy link
Member

amit1rrr commented Mar 4, 2023

@devikasharma97 yes, you're right. It's a known limitation at the moment.

Context

For a long time, GitHub didn't offer an API to resolve / unresolve a conversation. Recently, Github launched an API to resolve / unresolve a conversation.

Problem

GitHub requires "write repository" permission to be able to resolve / unresolve a conversation via the API. Currently we don't ask for this permissions as it was not required until now.

Solution

We'll soon be requesting "write repository" permission so we can resolve a conversation on our user's behalf. This permission would also enable us to build some advanced feature like offer & accept suggestions directly from the code review comments UI.

We will keep this issue open for tracking purposes.

@amit1rrr amit1rrr changed the title ReviewNB is not marking comments as resolved in GitHub Sync conversation status (Resolved | Unresolved) between ReviewNB & GitHub Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants