New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE when cancelling proxy branch #339

Open

horacimacias opened this issue Sep 12, 2017 · 1 comment

horacimacias commented Sep 12, 2017 •

edited by deruelle

Loading

Using sip-servlets 4.0.125, ProxyBranchImpl's cancel method does

if(lastResponse.getStatus() > Response.OK && !recursedBranches.isEmpty()) {

problem is recursedBranches can be null so a NPE is thrown.
Probably something like this would help:

if(lastResponse.getStatus() > Response.OK && recursedBranches != null && !recursedBranches.isEmpty()) {

horacimacias pushed a commit to horacimacias/sip-servlets that referenced this issue


          Fix for RestComm#339

a42001c

horacimacias mentioned this issue

Fixes for 339 and 340 #341

Open

Contributor

jaimecasero commented Nov 29, 2017

thanks for reporting, ill check TCK testsuite with this change and merge appropiately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment