Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with LOG_SETTINGS #5

Open
djarecka opened this issue May 16, 2019 · 6 comments
Open

problems with LOG_SETTINGS #5

djarecka opened this issue May 16, 2019 · 6 comments

Comments

@djarecka
Copy link
Member

@satra - I don't know which versions you were using, but I just installed sanic and it didn't like your LOG_SETTINGS. Some of your fields were not present sanic.log.LOGGING_CONFIG_DEFAULTS and were causing errors. This is the version that works for me, but not sure if this is what you want, I simply removed the fields:
https://github.com/djarecka/voice-backend/blob/logger_issues/serve.py

cc: @sanuann

@satra
Copy link
Contributor

satra commented May 16, 2019

search for LOG_SETTINGS in the sanic source tree. we should probably restrict sanic (and other dependencies) to a specific version

@djarecka
Copy link
Member Author

@satra - not sure, why I should be searching. If you don't specify your log_config, it uses LOGGING_CONFIG_DEFAULTS that looks like this

I'm not sure for which version your log_config works

@djarecka
Copy link
Member Author

@satra - do you actually care about the fields that I removed in my branch?

@satra
Copy link
Contributor

satra commented May 16, 2019

the things that you commented are exactly what i added to save the files on our mit server. probably the only thing you need to change is the path.

@djarecka
Copy link
Member Author

@satra you're right, I thought for moment that it doesn't like the keys. Is the current dir fine? just 'filename': "console.log" etc.

@djarecka
Copy link
Member Author

@sanuann - this version should work for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants