Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walkthrough testing on Mac #122

Closed
yarikoptic opened this issue May 29, 2024 · 4 comments
Closed

Add walkthrough testing on Mac #122

yarikoptic opened this issue May 29, 2024 · 4 comments
Assignees

Comments

@yarikoptic
Copy link
Member

https://github.com/ReproNim/containers/blob/master/.github/workflows/tests.yaml

testing is trivial -- just running

bash <(sed -n -e '/^ *#!/,/^```$/p' README.md | grep -v '```')

which runs that snippet from README.md with datalad-container -- so just needs installation of git-annex and datalad-container,. likely using datalad-installer.

@jwodder
Copy link
Collaborator

jwodder commented May 29, 2024

@yarikoptic I'm unclear what you're asking for. Do you want the tests.yaml workflow to include testing on macOS, or something else?

@yarikoptic
Copy link
Member Author

@yarikoptic I'm unclear what you're asking for. Do you want the tests.yaml workflow to include testing on macOS...?

yes

@yarikoptic
Copy link
Member Author

odd, I think I saw @jwodder's statement that it is not trivial to add docker support on mac, and then mine that I have tried myself too in https://github.com/yarikoptic/docker-gh-action-test but that did not work out fully (docker did not start) so let's indeed postpone

@jwodder
Copy link
Collaborator

jwodder commented Jun 5, 2024

@yarikoptic Those comments were in my PR: #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants