Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddOffset doesn't append #9

Open
JustArion opened this issue Jul 13, 2024 · 1 comment
Open

AddOffset doesn't append #9

JustArion opened this issue Jul 13, 2024 · 1 comment

Comments

@JustArion
Copy link

In PatternScanResult.cs#L35 the Offset is added to the return value, but the current value is never updated in the struct.

According to the summary

Appends to the existing offset if the offset is valid.

Instead, a new instance is returned with the added offset but doesn't update the existing struct the method is a part of.

@JustArion
Copy link
Author

The quality of life case is that

somePattern = somePattern.AddOffset(offset);

is more tedious than

somePattern.AddOffset(offset);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant