Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chromaticraft] charged aura cleaner doesn't seem to do anything #3409

Open
hacker-on-steroids opened this issue Sep 19, 2024 · 3 comments
Open

Comments

@hacker-on-steroids
Copy link

hacker-on-steroids commented Sep 19, 2024

the CC manual entry for the inert cleaner makes me believe it removes warp
the thaumcraft manual entry tells me nothing
the wiki says it prevents warp events from happening

and from testing it seems to do absolutely nothing - i still get warp events, and the sanity checker doesn't seem to show any difference
2024-09-19_12 31 47

@EyeDeck
Copy link
Collaborator

EyeDeck commented Oct 7, 2024

The wiki entry is wrong, the charged aura cleaner slowly reduces your warp. All kinds: temporary warp, normal/sticky warp, and permanent warp. You're intended to throw it in your aura pouch with the rest of your pendants and then basically forget about it.

@hacker-on-steroids
Copy link
Author

thanks
i tried reading through the code but had no idea where to start
is the charged cleaner Chromaticraft/ModInterface/ThaumCraft/ItemWarpProofer.java ?
and the warp removal actually happens in dragonapi from what i've gathered
i'm confused because it doesn't define the ingame name or sprite or itemID or anything really, searching the CC github for "charged aura cleaner" got me nowhere
am i supposed to run the game in a debugger or something to figure out where stuff is?

@EyeDeck
Copy link
Collaborator

EyeDeck commented Oct 8, 2024

I've heard others describe Reika's code as "nebulous", 😉 There's a method to it, but it can be tricky to track down where, precisely, in the code stuff lives.

Anyway, yes, you're in exactly the right place.

I guess you'll wanna look in the Chromaticraft .jar for ./assets/chromaticraft/lang/en_US.lang, which doesn't seem to be on Github for some reason, to find most things' internal names, which in this case is chroma.warp. This particular item is trickier than most, because the name is then further modified here at runtime, prefixed with either "Charged " or "Inert " depending on metadata. From chroma.warp you can work out here that it lives in ItemWarpProofer.class, and from there you can track down where it's actually defined. I think Chromaticraft would be very difficult for anyone other than Reika to work on, lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants