Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input errors #1

Open
jeffreysdempsey opened this issue Nov 14, 2016 · 3 comments
Open

Input errors #1

jeffreysdempsey opened this issue Nov 14, 2016 · 3 comments

Comments

@jeffreysdempsey
Copy link

Two thoughts on user input. When input is entered that doesn't resolve to a passage (i.e. Hezekiah 1), nothing happens. I think an error message or some other feedback would be helpful in these cases.

Also, some of abbreviations for books don't work Such as Jnh for Jonah and Nb for Numbers. The audio comes up in these particular instances, which tells me that these abbreviations are indexed in the ESV audio, but but not for your lookup. If I am changing from another text to one of these, the audio changes, but the text stays on the old passage instead of going blank or returning an error. A helpful and thorough list of abbreviations can be found here:

@sircharleswatson
Copy link
Contributor

@jeffreysdempsey I'm taking the passage input and appending it directly to the API URL. I just tried those two abbreviations you mentioned. They aren't supported by their API. :P

So we'd have to build some crazy regex to get all the passages inputted and check all the various abbreviations.

@jeffreysdempsey
Copy link
Author

No worries. I was just playing around and found that. I know almost nothing about web development. Just glad to help in any small way. It's a great project!

@sircharleswatson
Copy link
Contributor

@jeffreysdempsey reopening because I got it working last night/this morning. :) Keeping the issue here for the second task: error handling

Go ahead and try out the abbreviations. It should work well now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants