Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't compile with OTP 27 #105

Open
EarlPitts opened this issue Aug 15, 2024 · 1 comment
Open

Doesn't compile with OTP 27 #105

EarlPitts opened this issue Aug 15, 2024 · 1 comment

Comments

@EarlPitts
Copy link

Compiling Wrangler with OTP 27 results in the following error:

_build/default/lib/wrangler/src/wrangler_expand_rule.erl:7:2: Warning: export_all flag enabled - all functions will be exported

_build/default/lib/wrangler/src/wrangler_scan.erl:28:2: Warning: export_all flag enabled - all functions will be exported

===> Compiling _build/default/lib/wrangler/src/wrangler_epp_dodger.erl failed
_build/default/lib/wrangler/src/wrangler_epp_dodger.erl:310:34: syntax error before: 'else'

_build/default/lib/wrangler/src/wrangler_epp_dodger.erl:70:2: function scan_form/2 undefined
_build/default/lib/wrangler/src/wrangler_epp_dodger.erl:290:31: function scan_form/2 undefined

make: *** [Makefile:11: compile] Error 1

We suspect that it's related to the new maybe expression, which is on by default in OTP 27.
It's possible that changing else to 'else' and adding the maybe keyword would be enough.

@paulo-ferraz-oliveira
Copy link

I don't think that'll be enough (tried it locally) because there's a few new defaults for 27 that break compilation. You can go the "ignore all warnings" route by tweaking rebar3 but you might be missing a good opportunity to update as-it-should. This is being discussed in ErlEF's Slack channel #build-and-packaging, fyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants