Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:latest Docker tag out of date - --rate-limiting flag not yet published to "stable" image #269

Open
DrEsteban opened this issue Sep 24, 2024 · 3 comments

Comments

@DrEsteban
Copy link
Contributor

DrEsteban commented Sep 24, 2024

At the time of writing (9/24/2024), the --rate-limiting flag introduced by PR #237 has not yet been built and released to the official memtier Docker image redislabs/memtier_benchmark:latest, even though it was merged 10 months ago on 11/16/2023.

Is there an update on when it will be available? Is it expected for there to be such a delay in promoting new features to the "stable" Docker image?

UPDATE:
Sorry, should have provided more specifics 🙂

Digging deeper, it seems as if redislabs/memtier_benchmark:latest is still on 2.0.0, whereas :edge is on 2.1.1. (Latest available release at the time of writing.) So it makes sense that --rate-limiting isn't available in :latest, since it wasn't introduced until v2.1.0.

So I guess this question is more about - what is the expected cadence for updating the "stable" version of the memtier Docker image? Is there an ETA on when it will be updated to >=2.1.0?

@YaacovHazan
Copy link
Collaborator

@filipecosta90 ?

@filipecosta90 filipecosta90 self-assigned this Sep 24, 2024
@filipecosta90
Copy link
Collaborator

@DrEsteban and @YaacovHazan the latest docker version is redislabs/memtier_benchmark:2.1.1 and both the 2.1.0 and 2.1.1 versions have this feature.

docker run redislabs/memtier_benchmark:2.1.0 memtier_benchmark --help | grep rate
Unable to find image 'redislabs/memtier_benchmark:2.1.0' locally
2.1.0: Pulling from redislabs/memtier_benchmark
a8b1c5f80c2d: Pull complete 
14fb250f4a24: Pull complete 
a6c9d8d36585: Pull complete 
Digest: sha256:64f0abd43db50e75c1bd44a1b6a214e3b77efd37cbc16d8cabdc8c67d419acbe
Status: Downloaded newer image for redislabs/memtier_benchmark:2.1.0
      --rate-limiting=NUMBER     The max number of requests to make per second from an individual connection (default is unlimited rate).
                                 If you use --rate-limiting and a very large rate is entered which cannot be met, memtier will do as many requests as possible per second.
                                 To use a generated key or object, enter:
                                   __key__: Use key generated from Key Options.
                                   __data__: Use data generated from Object Options.
      --generate-keys            Generate keys for imported objects

Not sure why latest is not pointing towards it. Will check and reply back. In the meantime please use redislabs/memtier_benchmark:2.1.1

@DrEsteban DrEsteban changed the title --rate-limiting flag not yet published to official Docker image :latest Docker tag out of date - --rate-limiting flag not yet published to "stable" Docker image Sep 24, 2024
@DrEsteban DrEsteban changed the title :latest Docker tag out of date - --rate-limiting flag not yet published to "stable" Docker image :latest Docker tag out of date - --rate-limiting flag not yet published to "stable" image Sep 24, 2024
@DrEsteban
Copy link
Contributor Author

Sorry @filipecosta90 & @YaacovHazan, I should have dug a little deeper and provided more specifics in my original post.

This is less an "issue" and more an inquiry about when the :latest tag will be updated to include this feature. (:latest is still on 2.0.0, and this feature wasn't introduced until 2.1.0) I've updated the contents & title of my original post!

Though, judging from @filipecosta90's reply, sounds like there is an expectation that the :latest tag should have already been updated by this point, so it's just a matter of making it happen. Thanks so much for taking a look!

In general though, how much "bake time" should users of memtier expect when it comes to promoting new features from :edge to :latest/stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants