Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many dependencies from lock files #18

Open
ret2libc opened this issue Jul 13, 2022 · 2 comments
Open

too many dependencies from lock files #18

ret2libc opened this issue Jul 13, 2022 · 2 comments

Comments

@ret2libc
Copy link
Collaborator

deplist looks at yarn.lock and package-lock.json files to determine the dependencies of a package. While these dependencies might be used at runtime(or during testing) by the component, they are not "bundled" within the source code base. Usually bundled dependencies in NPM projects are under the ./node_modules directory and they have their own package.json file there, listing the properties of the dependency.

By using yarn.lock and package-lock.json files to determine dependencies without any way to differentiate between bundled dependencies and other types, we can generate too many false positives.

@ret2libc
Copy link
Collaborator Author

See #17 for a proposed solution

@ret2libc
Copy link
Collaborator Author

https://koji.fedoraproject.org/koji/buildinfo?buildID=1932309 is an example of such component that generates too many false positives due to lock files being analyzed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant