Nitpick: SAFE
and BALANCER_MULTISIG
are the same value and are used inconsistently
#3
Labels
SAFE
and BALANCER_MULTISIG
are the same value and are used inconsistently
#3
Impact
The casting of
address(SAFE))
are unnecessary if you useBALANCER_MULTISIG
https://github.com/onchainification/aura_locker_v2/blob/07294ae3638909ecd768a6a0f831fa513abe91a0/src/AuraLockerModule.sol#L20-L21
Which is what's done in
onlyGovernance
https://github.com/onchainification/aura_locker_v2/blob/07294ae3638909ecd768a6a0f831fa513abe91a0/src/AuraLockerModule.sol#L67C1-L71C6
Mitigation
You could alternatively change
onlyGovernance
to useaddress(SAFE)
and make the code consistentThis has no impact on the bytecode so it's not a big deal
The text was updated successfully, but these errors were encountered: