Player Gets Keys Back

[LittleCube-hax]

The player will get their keys for a dungeon back if they unlock a door, save and load.

[LittleCube-hax]

Some small research on this:

This is the line that checks whether a locked door is still locked. If so, set unk_1A6 to 10, denoting that the door should be drawn as "fully locked" (on a scale of 0 to 10, 0 being a complete absence of the chains drawn as explained by this line of z_actor).

This is part of a later commit of the decomp that documents what the types of doors are. What is now confirmed by zeldaret is that ENDOOR_TYPE_1 (now ENDOOR_TYPE_LOCKED in that later commit) denotes that a door should be treated as locked, and the game should perform the relevant flag checks.

What needs to be done to implement key save reconstruction is simply to document the switch flag ids of each locked door (there are 9 total), and then upon loading a save: iterate through the flags in gSaveContext.cycleSceneFlags[Play_GetOriginalSceneId(<whatever-dungeon-scene-id>)] and count how many doors have been unlocked in each of the four dungeons. Subtract that from the number of small keys the server says the player has for each respective dungeon, and that is the value of keys the player should now be set to have.

Implementing this change would almost complete the save reconstruction feature, aside from setting Rupees, BankRupees, and the ammo values into AP DataStorage.