Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own package name instead of direct class #7

Open
wf9a5m75 opened this issue Sep 20, 2018 · 2 comments
Open

Use own package name instead of direct class #7

wf9a5m75 opened this issue Sep 20, 2018 · 2 comments

Comments

@wf9a5m75
Copy link
Collaborator

Current Behavior

This plugin currently makes Firestore under the window property directly.

    <js-module src="www/firestore.js" name="Firestore">
      <clobbers target="Firestore"/>
    </js-module>

There is a possibility to conflict with other plugins.

Expected Behavior

One suggestion is to create own package name.
For example, my plugin creates plugin.google.maps in order to prevent conflicting with others.

You know what even Google makes own package name firebase.firestore.Firestore.

Would you like to create your plugin move to plugin.firebase.firestore.Firestore?
( If you use plugin.firesbase.firestore, developers can understand to just add plugin. )

@wf9a5m75 wf9a5m75 changed the title Use own package name instead of direct class name Use own package name instead of direct class Sep 20, 2018
@ReallySmallSoftware
Copy link
Owner

This does seem like a good idea.

@wf9a5m75
Copy link
Collaborator Author

wf9a5m75 commented Oct 7, 2018

I have been developing own library for firebase realtime database these days.
I will come back for this library in two weeks.

I aware current JS API implementation of this library has several problems to archive the plugin.firebase.firestore.Firestore.
Actually recreating a new library from scratch is faster than modifying this library.

I will invite you to my current work project in couple of days :) Just a moment please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants