bug: Patch option unsupported when it is supported when trying to select patch

[oSumAtrIX]

Bug description

Seems like some logic is incorrect:

Version of ReVanced Manager and version & name of app you are patching

1.23

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• The bug is only related to ReVanced Manager.

[KobeW50]

Note that after setting the patch option, the Spoof client patch will automatically become selected when another patch is selected/deselected.

Screen_Recording_20241117_023443_ReVanced.Manager.mp4

(Also, the string in the warning is missing punctuation)

[MNLierman]

I have had the exact same problem for over a month. Thanks for reporting this, but please make sure you provide error messages in text form, Google doesn't transcribe error screenshots. Putting the error message in quotes like I've done a few times to try to find anything about this, comes back with zero results. It took me 30 minutes for searching and I had to word my searches very carefully in order to find this, but I'm glad I did. I didn't think to go back out of the patches and back in to see if it checked the box.

Here is my report, error message included:

Issue Report: Unable to Enable "Spoof Client" Patch in ReVanced Manager v1.23.2

Summary:
When attempting to enable the "Spoof Client" patch in ReVanced Manager version 1.23.2, the patch cannot be enabled even after filling in the required client ID. (The error message received is: "This patch contains a required option that is not supported by this app."

Steps to Reproduce:

1. Open ReVanced Manager version 1.23.2.
2. Select the desired app to patch.
3. Fill in the required client ID in the provided field and press save.
4. Attempt to enable the "Spoof Client" patch.
5. Receive an error message: "This patch contains a required option that is not supported by this app."
6. Close ReVanced Manager.
7. Reopen ReVanced Manager and attempt to enable the "Spoof Client" patch again.
8. Notice that the client ID is erased and the field indicates in red that the client ID is required.
9. Fill in the client ID again and attempt to enable the patch.
10. Receive the same error message.
11. Simply go out of the patches screen after verifying you have provided characters in the client ID box, then go back into the patches view, and the box will be checked.

Observed Behavior:

• The error message "This patch contains a required option that is not supported by this app" is displayed after filling in the client ID.
• When attempting again after closing and reopening the app, the client ID field is cleared, and the error message is repeated.
• After revisiting the apps and patches screen and reselecting the app to patch, the "Spoof Client" checkmark finally retains and the patch is now enabled.

Expected Behavior:

• The patch should be enabled if the required fields were correctly provided for the patch.
• The error message should clearly indicate that the required information must be provided before the patch can be enabled.
• The app should validate if the fields were provided (in this case the client ID), and then enable the patch.
• When allowing uploads of patches, there should be clear checks that the patch provides the necessary callback options. The error message doesn't match the actual issue; is the patch in charge of selecting which error message will appear?

Possible Cause:
This issue might stem from the patch not providing the necessary callback/status to Revanced Manager that the required field (client ID) has been filled.

Suggested Improvement:

• Update the error message to: "Please ensure the required Client ID is filled in to enable this patch." / “Please ensure all required fields are filled in to enabled this patch.” The patch could provide the name of the textbox field required, and when checking if the box is empty, Revanced could provide the box name in any messages, making the errors more clear.
• Implement a validation check to confirm that the client ID field is filled before enabling the patch.
• Ensure that patches uploaded to the database properly communicate the filled status of any required fields to the app. This may require a change in how checks are performed when an updated patch is uploaded to the database. Uploaded patches should include names/handles of the fields required so that Revanced can check those fields properly, or that the patch provides a callback stating that the fields were filled in. The uploader tool used by the developers should kick back an error to them if the patch does not provide the necessary information Revance needs in order to ensure that it provides proper error message handling. Not sure exactly how your patch databases work, so this may be a rudimentary view.

Environment:

• ReVanced Manager version: 1.23.2
• Android version: 14
• Patch: Spoof Client

Additional Information:

• This issue may be more prevalent on specific devices due to how they handle the patch manager.
• Q: The error message states “not supported by this app,” this to implies there is another app which supports Revanced patches? Not that I've ever heard of.

Tagging: @TheAabedKhan, @oSumAtrIX

Screenshots: