Skip to content

Probability of Denial of Service due to lack of error caching

High
alexandreteles published GHSA-852x-grxp-8p3q Dec 27, 2023

Package

ReVanced/revanced-api (ReVanced)

Affected versions

71f81f7f20cd26fd707335bca9838fa3e7df20d2 and under

Patched versions

N/A

Description

Summary

Lack of error caching causes rate limit to be triggered thus increasing server load.

Details

Errors are not being cached (or properly cached) on Cloudflare for the ReVanced API, with multiple requests to the API repeatedly resulting in a rate-limiter kicking in to prevent being attacked.

PoC

In https://revanced.app @ 03df6ba641c0db8258b6e929208930ad86f72ffc, when the API is down, the site will retry the accessing the API every ~3 seconds (which isn't ideal since we're just unintentionally dosing the API #208)

Suggestion

Implement proper error caching for the ReVanced API.

Impact

All users using the API

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

CVE ID

CVE-2023-52075

Weaknesses

Credits