Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo.lock file #697

Closed
KSJ2000 opened this issue Oct 15, 2024 · 4 comments
Closed

Add Cargo.lock file #697

KSJ2000 opened this issue Oct 15, 2024 · 4 comments
Assignees

Comments

@KSJ2000
Copy link

KSJ2000 commented Oct 15, 2024

Please add the Cargo.lock file so that when building the nix derivation for the rust implementation of binwalk, it will not needed to define each dependency and it's hash, because the cargoHash will be used.
https://nixos.org/manual/nixpkgs/stable/#rust
It'd be great if you could also add a nix derivation for a fully reproducible build of binwalk, since what is from the Dockerfile for sure isn't, since the answer is no to the question: will this result in the same build inputs in half a year, or maybe 2 years.

RUN apt-get update && apt-get upgrade -y && apt-get install -y git

@devttys0 devttys0 self-assigned this Oct 15, 2024
@devttys0
Copy link
Collaborator

Added Cargo.lock to the git repo. I like the nix idea, I'll leave this issue open until that is implemented. Thanks!

@devttys0
Copy link
Collaborator

NixOS/nixpkgs#350300

@KSJ2000
Copy link
Author

KSJ2000 commented Nov 1, 2024

Do I not understand this correctly?

These scripts install the required Binwalk build and runtime system dependencies, except for the Rust compiler itself.

pip3 install --upgrade git+https://github.com/marin-m/vmlinux-to-elf

# Install dumpifs

Are those not needed for runtime?
Like... where are the dependencies in the buildInputs...
Just because V3 builds, doesn't mean it also has all the necessary dependencies it needs to work in every scenario.
Some dependencies don't even exist in nixpkgs.
I'm trying to get them merged, but it will take some more time until everything is done.
NixOS/nixpkgs#349055
NixOS/nixpkgs#348768

@devttys0
Copy link
Collaborator

NixOS/nixpkgs#357991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants