-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cargo.lock file #697
Labels
Comments
Added Cargo.lock to the git repo. I like the nix idea, I'll leave this issue open until that is implemented. Thanks! |
Do I not understand this correctly? binwalk/dependencies/README.md Line 3 in e0a4434
Line 9 in e0a4434
Line 5 in e0a4434
Are those not needed for runtime? Like... where are the dependencies in the buildInputs... Just because V3 builds, doesn't mean it also has all the necessary dependencies it needs to work in every scenario. Some dependencies don't even exist in nixpkgs. I'm trying to get them merged, but it will take some more time until everything is done. NixOS/nixpkgs#349055 NixOS/nixpkgs#348768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please add the Cargo.lock file so that when building the nix derivation for the rust implementation of binwalk, it will not needed to define each dependency and it's hash, because the cargoHash will be used.
https://nixos.org/manual/nixpkgs/stable/#rust
It'd be great if you could also add a nix derivation for a fully reproducible build of binwalk, since what is from the Dockerfile for sure isn't, since the answer is no to the question: will this result in the same build inputs in half a year, or maybe 2 years.
binwalk/Dockerfile
Line 6 in d0c89d8
The text was updated successfully, but these errors were encountered: