-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font_collection_num_fonts_overflow test fails on 32-bit architectures #127
Comments
Can confirm. |
The issue is that the code takes a 32-bit number, converts it to a usize and then multiplies it by SIZE. Afaict SIZE is always a small number so on 64-bit systems this can never overflow. However on 32-bit systems it can and does overflow. The change below makes the test pass, but I'd like some feedback whether this is the correct approach before I go and add it as a distribution patch.
|
@plugwash yes, I know that this is because |
I think this issue can be closed at this point? I recently upgraded to v0.24.1 in Debian and the refactored tests passed with no patches. |
The text was updated successfully, but these errors were encountered: