Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection responses have an extra empty map as the last element #64

Open
cddr opened this issue Dec 16, 2014 · 2 comments
Open

Collection responses have an extra empty map as the last element #64

cddr opened this issue Dec 16, 2014 · 2 comments

Comments

@cddr
Copy link

cddr commented Dec 16, 2014

Is there a reason for responses returning a collection of github objects to include an empty element at the end or is that a bug?

(pulls/pulls "Raynes" "tentacles" {:auth "cddr:M24thbdinF"
                                                     :per-page 1})
=> [{:created_at "", :assignee nil.....} {}]

Would you accept a PR fixing it or would that be considered a breaking change?

@Raynes
Copy link
Owner

Raynes commented Dec 16, 2014

There are a lot of issues with the lazy-seq based pagination. Any pull requests to fix those would be much appreciated.

@jjl
Copy link

jjl commented Mar 18, 2017

Hello,

I think I squashed this one in my clojars-published fork, please try it out: irresponsible/tentacles.

Raynes unfortunately passed away, but we will try and keep his legacy alive. A v0.6.0 has been uploaded to clojars as 'irresponsible/tentacles'.

Please find more details in this post:
https://groups.google.com/forum/#!topic/clojure/UJetyHj-BPE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants