Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #3

Open
paulkugaev opened this issue Feb 14, 2019 · 2 comments
Open

Memory leak #3

paulkugaev opened this issue Feb 14, 2019 · 2 comments

Comments

@paulkugaev
Copy link

Your solution has a memory leak when using databinding. You should either mention that we have to set GlobalLayoutListener to null at every configuration change or remove it from text's viewTreeObserver

@saintjab
Copy link

@paulkugaev How did you solve that? I just realised changing configuration keeps calling afterTextChanged method until it crashes the app. I need a solution.

@paulkugaev
Copy link
Author

@saintjab the whole code is aimed on reconfiguring toolbar layout after the view tree has been inflated. removing GlobalLayoutListener (which leaks) leads to broken functionality. the easiest workaround - not using this library until @RaviKoradiya fixes the issue and instead creating a regular TextView inside Toolvar coz u can consider Toolbar as a regular FrameLayout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants