Disassembler #112
Closed
Ratstail91
started this conversation in
General
Replies: 3 comments 6 replies
-
I can see breaks standard format. I will correct this |
Beta Was this translation helpful? Give feedback.
0 replies
-
After the last option for disassembler maybe is time to rethink the interpreter |
Beta Was this translation helpful? Give feedback.
5 replies
-
This is a keep alive packet :-) |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@hiperiondev Let's move disassembler talk here, since it's basically a mini-project of it's own.
I reverted the #111 merge, because the default disassembly wasn't working correctly - in fact, it would hang in the default mode.
Do you think you could split the two modes apart, so they're not interleaved like they are now?
Edit: Also, since it's getting more complex, it might be a good idea to add in some simple tests for it too.
Beta Was this translation helpful? Give feedback.
All reactions