Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blink.cmp source #510

Open
Saghen opened this issue Nov 20, 2024 · 3 comments
Open

feat: blink.cmp source #510

Saghen opened this issue Nov 20, 2024 · 3 comments

Comments

@Saghen
Copy link
Contributor

Saghen commented Nov 20, 2024

Is your feature request related to a problem? Please describe.
The current completion system uses the built-in completions and does not support external completion engines

Describe the solution you'd like
Support for external completion engines such as blink.cmp and/or nvim-cmp

Additional context
Hey there, love the plugin! It's getting me to finally switch off my shell filled with aliases 😄 I'm the author of blink.cmp and was curious if you'd accept a built-in source for it. I believe I'll need to make some changes on blink's side which I'm more than happy to do.

@Ramilito
Copy link
Owner

Hey there, love the plugin! It's getting me to finally switch off my shell filled with aliases 😄

I'm in the same boat as you, think this plugin turned out really good!
Seen blink.cmp around but never had the time to test it out, just did and liking it a lot!

Would the end results be that we have an optional dependency to an external cmp engine but if not, we fallback on the built-in one?

I have not looked at the code for cmp sources so not sure what changes needs to be done on our side but I like the idea and let me know if you need me to do anything!

@mosheavni
Copy link
Collaborator

i think it's wise.
if you plan on implementing it, i think it must come with support for the most popular (nvim-cmp) and yours at the same time.

@Ramilito
Copy link
Owner

i think it's wise. if you plan on implementing it, i think it must come with support for the most popular (nvim-cmp) and yours at the same time.

If it's an optional dep with fallback on the current built-in I would say it's enough to make the implementation extensible so that nvim-cmp can be added separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants