Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make skew version warning optional #506

Open
roman-kiselenko opened this issue Nov 11, 2024 · 1 comment
Open

feat: make skew version warning optional #506

roman-kiselenko opened this issue Nov 11, 2024 · 1 comment

Comments

@roman-kiselenko
Copy link

Is your feature request related to a problem? Please describe.

If the client version is different from the server. A warning popup as message:

WARNING: version difference between client (1.31) and server (1.28) exceeds the supported minor version skew of +/-1

Describe the solution you'd like

Make this warning optional, so that when it opens it does not interrupt the display.

Describe alternatives you've considered

none

Additional context

I would like to try adding this myself.

Screen.Recording.2024-11-11.at.11.35.31.mov
@roman-kiselenko roman-kiselenko changed the title feat: Make skew version warning optional feat: make skew version warning optional Nov 11, 2024
@Ramilito
Copy link
Owner

Ramilito commented Nov 12, 2024

Hi! Awesome suggestion!
You are more than welcome to try adding this yourself, let me know if you need anything!

Just a note on the config, since changing old settings tend to be breaking changes, I usually try to make them easy to extend. So in this case, maybe instead of:
skew = true, we would have, skew = {enabled = true}, if later on someone wants to expand on that, it's easier for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants