Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as.ts(<zoo_object>, start = ..., end = ...) #65

Open
zeileis opened this issue Sep 15, 2022 · 1 comment
Open

as.ts(<zoo_object>, start = ..., end = ...) #65

zeileis opened this issue Sep 15, 2022 · 1 comment
Assignees
Labels

Comments

@zeileis
Copy link

zeileis commented Sep 15, 2022

When trying out certain changes in zoo, we noticed that this leads to problems in TSstudio because you have calls like as.ts(<zoo_object>, start = ..., end = ...). Up to now the start/end arguments were simply ignored but this may change in future versions.

It would be safer if you distinguish xts and zoo objects in the coercions in the following places:

https://github.com/RamiKrispin/TSstudio/blob/master/R/correlation_functions.R#L188-L190
https://github.com/RamiKrispin/TSstudio/blob/master/R/util_functions.R#L272-L274

For the xts objects the start/end are used and improve the output of as.ts(). But for zoo objects they currently make no sense.

@RamiKrispin
Copy link
Owner

Hi @zeileis, sorry for the late response, missed this issue. Thanks, I will check it and update it if needed.

@RamiKrispin RamiKrispin self-assigned this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants