Revert "Remove 0.5 ohm increase to resistance" #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. Could you tell, please, do you mean |
|
Hi, Yeah so there are pinecil and pinecil-dev chats in the pine64 chat setup. Activity there varies but often pinecil related changes are discussed there. Usually tickets are made after discussion on those chats depending on what's found. Both locations are valid for chats; I want everything ticketed on GitHub as it's the primary place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1728
Reverting this as it appears to maybe sorta help one specific PSU out of lots that have been tested.
So given it helps approximately 1 charger out of 100's-100k's it has been decided in chat that this is not really worth it.
We may bring this back as a setting later on